solaris11_network: Handle solaris 11 zone interfaces #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # index 3 | ||
| # inet6 tunnel src fe80::1 tunnel dst fe80::2 | ||
| # tunnel security settings --> use 'ipsecconf -ln -i ip.tun1' | ||
| # tunnel hop limit 60 tunnel encapsulation limit 4 | ||
| # inet 10.0.0.208 --> 10.0.0.210 netmask ff000000 | ||
| #qfe1: flags=2000841<UP,RUNNING,MULTICAST,IPv6> mtu 1500 index 3 | ||
| # qfe1: flags=2000841<UP,RUNNING,MULTICAST,IPv6> mtu 1500 index 3 | ||
| # usesrc vni0 |
There was a problem hiding this comment.
is chefstyle doing this? because its actually mangling that comment a bit... the indentation is now off in the comment....
|
yeah, so 👍 i guess i only have a question about the comment indentation mangling and if that is chefstyle doing that or not. |
|
I’ll revert the comments to their previous format. Chefstyle is not doing that. I made some changes to suppress rubocop alerts before I figured out chef style. Sorry. |
PHYSRUNNING is now a valid flag for an interface. The Solaris 11 zones "route -n get default” command output returns the interface name, net0, but not the specific instance net0:2. The output changed from Solaris 10 to Solaris 11. Use the verbose output "route -v -n get default" to find the interface index and use the name and index to find the full interface name from the ifconfig -a output.
MarkGibbons
force-pushed
the
solaris11_network
branch
from
dd869ae
to
30fe078
Compare
|
👍 |
MarkGibbons
changed the title
|
Code looks good to me. @thommay do you have any concerns? |
|
Looks good to me, thanks @MarkGibbons! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHYSRUNNING is now a valid flag for an interface.
The Solaris 11 zones "route -n get default” command output returns the
interface name, net0, but not the specific instance net0:2. The output
changed from Solaris 10 to Solaris 11. Use the verbose output
"route -v -n get default" to find the interface index and use the
name and index to find the full interface name from the ifconfig -a
output.
OHAI network is sort of incomplete for solaris 11 zone network interfaces. The flags are not reported because PHYSRUNNING might be in the status. The default_ipaddress isn't returned because output from the "route -n get default" command changed between solaris 10 and solaris 11.
I changed a couple of things to fix default rubocop alerts before I figured out chef-style. The modules do pass chef-style 0.3.0 now, but there are a few, probably unneeded, fixes for other default rubocop alerts I left in the code.
I've tested the code on Solaris 11, and u6 and u11 versions of Solaris 10.
Thanks,
Mark